Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: improve inconsistency edge case #251

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Backend: improve inconsistency edge case #251

merged 2 commits into from
Jan 25, 2024

Conversation

knocte
Copy link
Member

@knocte knocte commented Jan 24, 2024

Closes #250

This is the first part of a bugfix for issue 250 [1]. The
exception was misleading because it was not really an
inconsistecy but rather lacking availability.

[1] #250
@knocte knocte changed the base branch from master to stable January 24, 2024 16:59
This InconsistentResultFromDifferentServersOfSameCurrency
exception type was introduced in [1], but after implementing an
improvement[2] over the exception message and type of another
problem, I realised that the new exception thrown in [2]
wouldn't be covered by the exception type mentioned above, so we
need it to be more generic (to receive any exception as
innerException), so let's do that and rename it.

This commit in conjunction with [2] don't really fix issue
250 [3], but it might mitigate it, and anyway thanks to [1] if
it happens again, we will receive a different exception, with
different exception message as well (more helpful), so let's
just close [3] now.

Closes #250

[1] 8fa47e0
[2] 5eca671
[3] #250
@knocte knocte changed the title Improve inconsistency edge case Backend: improve inconsistency edge case Jan 24, 2024
@knocte knocte merged commit 8f30648 into stable Jan 25, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only 1 available server (when consistency settings requires 2) generates misleading exception
1 participant